dbxe
/
fusionpbx
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

SMS bugfix (#4850) 

This SMS bugfix works out two issues:
* SMS permissions were not properly included. This causes SMS functionality to be inaccessible if the system implementor works out a Lua SMS implementation
* If voicemail transcription doesn't exist for the voicemail the send_sms.lua script crashes. Added a nil check to prevent this.
This commit is contained in:
jpattWPC 2019-11-22 20:45:39 -06:00 committed by FusionPBX
parent 371d17f764
commit 100afacc21
3 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/voicemails/app_config.php
View File

@ -92,6 +92,10 @@
$apps[$x]['permissions'][$y]['groups'][] = "superadmin"; $apps[$x]['permissions'][$y]['groups'][] = "superadmin";
$apps[$x]['permissions'][$y]['groups'][] = "admin"; $apps[$x]['permissions'][$y]['groups'][] = "admin";
$y++; $y++;
$apps[$x]['permissions'][$y]['name'] = "voicemail_sms_edit";
$apps[$x]['permissions'][$y]['groups'][] = "superadmin";
$apps[$x]['permissions'][$y]['groups'][] = "admin";
$y++;
$apps[$x]['permissions'][$y]['name'] = "voicemail_local_after_email"; $apps[$x]['permissions'][$y]['name'] = "voicemail_local_after_email";
$apps[$x]['permissions'][$y]['groups'][] = "superadmin"; $apps[$x]['permissions'][$y]['groups'][] = "superadmin";
$apps[$x]['permissions'][$y]['groups'][] = "admin"; $apps[$x]['permissions'][$y]['groups'][] = "admin";

2
app/voicemails/voicemail_edit.php
View File

@ -553,7 +553,7 @@
echo "</td>\n"; echo "</td>\n";
echo "</tr>\n"; echo "</tr>\n";
if (permission_exists('sms_edit')) { if (permission_exists('voicemail_sms_edit')) {
echo "<tr>\n"; echo "<tr>\n";
echo "<td class='vncell' valign='top' align='left' nowrap='nowrap'>\n"; echo "<td class='vncell' valign='top' align='left' nowrap='nowrap'>\n";
echo " ".$text['label-voicemail_sms_to']."\n"; echo " ".$text['label-voicemail_sms_to']."\n";

4
resources/install/scripts/app/voicemail/resources/functions/send_sms.lua
View File

@ -77,7 +77,9 @@
message_length_formatted = format_seconds(message_length); message_length_formatted = format_seconds(message_length);
if (debug["info"]) then if (debug["info"]) then
freeswitch.consoleLog("notice", "[voicemail-sms] message length: " .. message_length .. "\n"); freeswitch.consoleLog("notice", "[voicemail-sms] message length: " .. message_length .. "\n");
freeswitch.consoleLog("notice", "[voicemail-sms] transcription: " .. transcription .. "\n"); if (transcription ~= nil) then
freeswitch.consoleLog("notice", "[voicemail-sms] transcription: " .. transcription .. "\n");
end
freeswitch.consoleLog("notice", "[voicemail-sms] domain_name: " .. domain_name .. "\n"); freeswitch.consoleLog("notice", "[voicemail-sms] domain_name: " .. domain_name .. "\n");
end end
local message_date = os.date("%A, %d %b %Y %I:%M %p", created_epoch) local message_date = os.date("%A, %d %b %Y %I:%M %p", created_epoch)