From ea0823ea4dd4880d3f7e62e5629c713cf322f478 Mon Sep 17 00:00:00 2001 From: Andrew Querol Date: Tue, 9 Mar 2021 16:15:01 -0600 Subject: [PATCH 1/2] Do not load base64 data into phrase edit. This will fix unnecessary memory usage/latency in this application when dealing with base64 recordings. --- app/phrases/phrase_edit.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/phrases/phrase_edit.php b/app/phrases/phrase_edit.php index d2c6d859d3..4c5625b831 100644 --- a/app/phrases/phrase_edit.php +++ b/app/phrases/phrase_edit.php @@ -296,8 +296,8 @@ unset($sql, $parameters); } -//get the recordings - $sql = "select * from v_recordings "; +//get the recording names from the database. Do not select everything otherwise we can pull in large base64 data for no reason + $sql = "select recording_name, recording_filename from v_recordings "; $sql .= "where domain_uuid = :domain_uuid "; $sql .= "order by recording_name asc "; $parameters['domain_uuid'] = $_SESSION['domain_uuid']; From 61bc654f610dae7e7be381c3471aa28b7c19d5d4 Mon Sep 17 00:00:00 2001 From: FusionPBX Date: Wed, 10 Mar 2021 00:01:18 -0700 Subject: [PATCH 2/2] Update phrase_edit.php --- app/phrases/phrase_edit.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/phrases/phrase_edit.php b/app/phrases/phrase_edit.php index 4c5625b831..72dcb1394f 100644 --- a/app/phrases/phrase_edit.php +++ b/app/phrases/phrase_edit.php @@ -296,7 +296,7 @@ unset($sql, $parameters); } -//get the recording names from the database. Do not select everything otherwise we can pull in large base64 data for no reason +//get the recording names from the database. $sql = "select recording_name, recording_filename from v_recordings "; $sql .= "where domain_uuid = :domain_uuid "; $sql .= "order by recording_name asc ";