diff --git a/app/extension_settings/extension_settings.php b/app/extension_settings/extension_settings.php index 6a7386d7e0..19c97820d4 100644 --- a/app/extension_settings/extension_settings.php +++ b/app/extension_settings/extension_settings.php @@ -55,7 +55,7 @@ } //process the http post data by action - if ($action != '' && is_array($extension_settings) && @sizeof($extension_settings) != 0) { + if (!empty($action) && is_array($extension_settings)) { //validate the token $token = new token; @@ -94,8 +94,8 @@ } //get order and order by - $order_by = $_GET["order_by"]; - $order = $_GET["order"]; + $order_by = $_GET["order_by"] ?? ''; + $order = $_GET["order"] ?? ''; //add the search if (isset($_GET["search"])) { @@ -154,7 +154,7 @@ $parameters['extension_uuid'] = $extension_uuid; $parameters['domain_uuid'] = $domain_uuid; $database = new database; - $extension_settings = $database->select($sql, $parameters, 'all'); + $extension_settings = $database->select($sql, $parameters ?? null, 'all'); unset($sql, $parameters); //create token @@ -194,9 +194,9 @@ // } //} echo ""; - echo button::create(['label'=>$text['button-search'],'icon'=>$_SESSION['theme']['button_icon_search'],'type'=>'submit','id'=>'btn_search','style'=>($search != '' ? 'display: none;' : null)]); - echo button::create(['label'=>$text['button-reset'],'icon'=>$_SESSION['theme']['button_icon_reset'],'type'=>'button','id'=>'btn_reset','link'=>'extension_settings.php?id='.$extension_uuid,'style'=>($search == '' ? 'display: none;' : null)]); - if ($paging_controls_mini != '') { + echo button::create(['label'=>$text['button-search'],'icon'=>$_SESSION['theme']['button_icon_search'],'type'=>'submit','id'=>'btn_search','style'=>(!empty($search) ? 'display: none;' : null)]); + echo button::create(['label'=>$text['button-reset'],'icon'=>$_SESSION['theme']['button_icon_reset'],'type'=>'button','id'=>'btn_reset','link'=>'extension_settings.php?id='.$extension_uuid,'style'=>(empty($search) ? 'display: none;' : null)]); + if (!empty($paging_controls_mini)) { echo "".$paging_controls_mini."\n"; } echo " \n";