From 2cbb4dbc31607ba58135947f8272af3c7e05d32b Mon Sep 17 00:00:00 2001 From: frytimo Date: Thu, 22 Aug 2024 15:41:10 -0300 Subject: [PATCH] remove instances where a pointer is used in a foreach loop for value (#7108) --- .../classes/basic_operator_panel.php | 6 ++-- app/call_block/call_block_edit.php | 8 ++--- app/call_centers/app_defaults.php | 2 +- app/call_centers/call_center_queue_edit.php | 4 +-- app/call_forward/call_forward_edit.php | 4 +-- app/calls_active/calls_active_inc.php | 4 +-- app/click_to_call/click_to_call.php | 2 +- .../resources/classes/conference_centers.php | 2 +- app/contacts/contacts_vcard.php | 6 ++-- app/destinations/destination_edit.php | 4 +-- .../resources/classes/destinations.php | 18 +++++------ app/devices/app_defaults.php | 6 ++-- app/devices/device_download.php | 2 +- app/devices/device_imports.php | 8 ++--- app/devices/device_profile_edit.php | 2 +- app/devices/device_vendor_functions.php | 2 +- .../resources/dashboard/device_keys.php | 4 +-- app/dialplan_inbound/dialplan_inbound_add.php | 2 +- .../resources/classes/dialplan.better.php | 10 +++---- app/dialplans/resources/classes/dialplan.php | 10 +++---- app/extensions/extension_edit.php | 8 ++--- .../resources/classes/extension.php | 4 +-- .../resources/dashboard/caller_id.php | 2 +- app/fax/fax_emails.php | 10 +++---- app/fax/fax_send.php | 2 +- app/fax/resources/functions/parse_message.php | 6 ++-- app/ivr_menus/ivr_menu_copy.php | 2 +- app/ivr_menus/ivr_menu_edit.php | 2 +- .../resources/functions/ivr_menu_xml.php | 2 +- app/modules/app_defaults.php | 2 +- app/modules/resources/classes/modules.php | 2 +- app/music_on_hold/music_on_hold_edit.php | 4 +-- app/number_translations/app_defaults.php | 2 +- .../resources/classes/number_translations.php | 2 +- app/phrases/app_defaults.php | 4 +-- app/phrases/phrase_edit.php | 2 +- app/provision/resources/classes/provision.php | 6 ++-- app/recordings/app_defaults.php | 4 +-- app/recordings/recordings.php | 2 +- .../resources/classes/switch_recordings.php | 2 +- app/sip_profiles/app_defaults.php | 4 +-- app/sip_profiles/sip_profile_copy.php | 4 +-- app/voicemail_greetings/app_defaults.php | 6 ++-- .../resources/classes/voicemail.php | 4 +-- .../resources/dashboard/voicemails.php | 2 +- app/voicemails/voicemails.php | 4 +-- app/xml_cdr/xml_cdr.php | 4 +-- app/xml_cdr/xml_cdr_search.php | 4 +-- core/databases/app_defaults.php | 2 +- core/default_settings/default_settings.php | 2 +- core/domain_settings/domain_setting_edit.php | 2 +- core/domain_settings/domain_settings.php | 2 +- core/events/resources/classes/events.php | 4 +-- core/groups/group_members.php | 4 +-- core/groups/permissions_copy.php | 2 +- core/groups/resources/classes/permission.php | 4 +-- core/menu/menu_item_list.php | 4 +-- core/permissions/app_defaults.php | 2 +- core/upgrade/index.php | 2 +- core/user_settings/user_setting_edit.php | 2 +- core/user_settings/user_settings.php | 2 +- resources/classes/database.php | 16 +++++----- resources/classes/directory.php | 4 +-- resources/classes/domains.php | 8 ++--- resources/classes/email.php | 2 +- resources/classes/event_socket.php | 2 +- resources/classes/groups.php | 2 +- resources/classes/schema.php | 30 +++++++++---------- resources/classes/sounds.php | 4 +-- resources/functions.php | 2 +- resources/login.php | 2 +- resources/switch.php | 24 +++++++-------- secure/fax_to_email.php | 2 +- 73 files changed, 170 insertions(+), 170 deletions(-) diff --git a/app/basic_operator_panel/resources/classes/basic_operator_panel.php b/app/basic_operator_panel/resources/classes/basic_operator_panel.php index bcbff94eb6..234726fb46 100644 --- a/app/basic_operator_panel/resources/classes/basic_operator_panel.php +++ b/app/basic_operator_panel/resources/classes/basic_operator_panel.php @@ -77,7 +77,7 @@ if (!class_exists('basic_operator_panel')) { //store extension status by user uuid if (isset($extensions)) { - foreach($extensions as &$row) { + foreach ($extensions as $row) { if ($row['user_uuid'] != '') { $ext_user_status[$row['user_uuid']] = $row['user_status']; unset($row['user_status']); @@ -97,7 +97,7 @@ if (!class_exists('basic_operator_panel')) { //build the response $x = 0; if (isset($extensions)) { - foreach($extensions as &$row) { + foreach ($extensions as $row) { $user = $row['extension']; if (!empty($row['number_alias'])) { $user = $row['number_alias']; @@ -143,7 +143,7 @@ if (!class_exists('basic_operator_panel')) { //add the active call details $found = false; if (isset($json_array['rows'])) { - foreach($json_array['rows'] as &$field) { + foreach ($json_array['rows'] as $field) { $presence_id = $field['presence_id']; $presence = explode("@", $presence_id); $presence_id = $presence[0]; diff --git a/app/call_block/call_block_edit.php b/app/call_block/call_block_edit.php index a46c8deb41..73e010a900 100644 --- a/app/call_block/call_block_edit.php +++ b/app/call_block/call_block_edit.php @@ -491,7 +491,7 @@ if (permission_exists('call_block_all') || permission_exists('call_block_ring_gr if (permission_exists('call_block_extension')) { if (!empty($extensions)) { echo " \n"; - foreach ($extensions as &$row) { + foreach ($extensions as $row) { $selected = ($call_block_app == 'extension' && $call_block_data == $row['extension']) ? "selected='selected'" : null; echo " \n"; } @@ -501,7 +501,7 @@ if (permission_exists('call_block_all') || permission_exists('call_block_ring_gr if (permission_exists('call_block_ivr')) { if (!empty($ivrs)) { echo " \n"; - foreach ($ivrs as &$row) { + foreach ($ivrs as $row) { $selected = ($call_block_app == 'ivr' && $call_block_data == $row['ivr_menu_extension']) ? "selected='selected'" : null; echo " \n"; } @@ -511,7 +511,7 @@ if (permission_exists('call_block_all') || permission_exists('call_block_ring_gr if (permission_exists('call_block_ring_group')) { if (!empty($ring_groups)) { echo " \n"; - foreach ($ring_groups as &$row) { + foreach ($ring_groups as $row) { $selected = ($call_block_app == 'ring_group' && $call_block_data == $row['ring_group_extension']) ? "selected='selected'" : null; echo " \n"; } @@ -521,7 +521,7 @@ if (permission_exists('call_block_all') || permission_exists('call_block_ring_gr if (permission_exists('call_block_voicemail')) { if (!empty($voicemails)) { echo " \n"; - foreach ($voicemails as &$row) { + foreach ($voicemails as $row) { $selected = ($call_block_app == 'voicemail' && $call_block_data == $row['voicemail_id']) ? "selected='selected'" : null; echo " \n"; } diff --git a/app/call_centers/app_defaults.php b/app/call_centers/app_defaults.php index 74d82b1fa3..7cd7080c2b 100644 --- a/app/call_centers/app_defaults.php +++ b/app/call_centers/app_defaults.php @@ -45,7 +45,7 @@ if ($domains_processed == 1) { $sql .= "and (t.call_center_queue_uuid is null or t.call_center_agent_uuid is null) "; $tiers = $database->select($sql, null, 'all'); if (!empty($tiers)) { - foreach ($tiers as $index => &$row) { + foreach ($tiers as $index => $row) { if ($row['call_center_queue_uuid'] == null && $row['queue_uuid'] != null) { $array['call_center_tiers'][$index]['call_center_queue_uuid'] = $row['queue_uuid']; } diff --git a/app/call_centers/call_center_queue_edit.php b/app/call_centers/call_center_queue_edit.php index c2753e29c7..f4b56d71e9 100644 --- a/app/call_centers/call_center_queue_edit.php +++ b/app/call_centers/call_center_queue_edit.php @@ -154,7 +154,7 @@ unset($sql, $parameters); if (!empty($tiers)) { - foreach ($tiers as &$row) { + foreach ($tiers as $row) { $call_center_agent_uuid = $row["call_center_agent_uuid"]; $call_center_queue_uuid = $row["call_center_queue_uuid"]; $queue_extension = $row["queue_extension"]; @@ -543,7 +543,7 @@ unset($sql, $parameters); if (!empty($call_center_queues)) { - foreach ($call_center_queues as &$row) { + foreach ($call_center_queues as $row) { $queue_name = $row["queue_name"]; $dialplan_uuid = $row["dialplan_uuid"]; $database_queue_name = $row["queue_name"]; diff --git a/app/call_forward/call_forward_edit.php b/app/call_forward/call_forward_edit.php index 31d2b28c25..cbd7ba4709 100644 --- a/app/call_forward/call_forward_edit.php +++ b/app/call_forward/call_forward_edit.php @@ -468,7 +468,7 @@ $result = $database->select($sql, $parameters, 'all'); unset($destinations); - foreach ($result as $x => &$row) { + foreach ($result as $x => $row) { $destinations[$x]['uuid'] = $row["follow_me_destination_uuid"]; $destinations[$x]['destination'] = $row["follow_me_destination"]; $destinations[$x]['delay'] = $row["follow_me_delay"]; @@ -510,7 +510,7 @@ echo "