dbxe/fusionpbx
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

voicemail_id is not guaranteed to be numeric so can't use the cast unless we protect against non numeric ids.

Browse Source
This commit is contained in:
markjcrane
2016-04-19 14:05:12 -06:00
parent 3758d84216
commit 2fd1a44842
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/voicemails/voicemails.php
+2 -2
View File
@@ -116,10 +116,10 @@ else {
//get the list //get the list
$sql = str_replace('count(*) as num_rows', '*', $sql); $sql = str_replace('count(*) as num_rows', '*', $sql);
if (strlen($order_by) > 0) { if (strlen($order_by) > 0) {
$sql .= ($order_by == 'voicemail_id') ? "order by cast(voicemail_id as int) ".$order." " : "order by ".$order_by." ".$order." "; $sql .= ($order_by == 'voicemail_id') ? "order by voicemail_id ".$order." " : "order by ".$order_by." ".$order." ";
} }
else { else {
$sql .= "order by cast(voicemail_id as int) asc "; $sql .= "order by voicemail_id asc ";
} }
$sql .= "limit ".$rows_per_page." offset ".$offset." "; $sql .= "limit ".$rows_per_page." offset ".$offset." ";
$prep_statement = $db->prepare(check_sql($sql)); $prep_statement = $db->prepare(check_sql($sql));