diff --git a/app/access_controls/access_controls.php b/app/access_controls/access_controls.php index 8f922869ba..258ae61aab 100644 --- a/app/access_controls/access_controls.php +++ b/app/access_controls/access_controls.php @@ -126,7 +126,7 @@ $sql .= ") "; } $database = new database; - $num_rows = $database->select($sql, $parameters ?? '', 'column'); + $num_rows = $database->select($sql, $parameters ?? null, 'column'); //get the list $sql = "select "; @@ -144,7 +144,7 @@ } $sql .= order_by($order_by, $order, 'access_control_name', 'asc'); $database = new database; - $access_controls = $database->select($sql, $parameters ?? '', 'all'); + $access_controls = $database->select($sql, $parameters ?? null, 'all'); unset($sql, $parameters); //create token diff --git a/app/bridges/bridge_edit.php b/app/bridges/bridge_edit.php index 173f258505..c981a22cbc 100644 --- a/app/bridges/bridge_edit.php +++ b/app/bridges/bridge_edit.php @@ -49,6 +49,13 @@ $action = "add"; } +//set the defaults + $bridge_uuid = ''; + $bridge_name = ''; + $bridge_destination = ''; + $bridge_enabled = ''; + $bridge_description = ''; + //get http post variables and set them to php variables if (!empty($_POST)) { $bridge_uuid = $_POST["bridge_uuid"] ?? null; @@ -59,7 +66,7 @@ } //process the user data and save it to the database - if (count($_POST) > 0 && empty($_POST["persistformvar"])) { + if (!empty($_POST) && empty($_POST["persistformvar"])) { //delete the bridge if (permission_exists('bridge_delete')) { @@ -152,8 +159,8 @@ $sql .= "where bridge_uuid = :bridge_uuid "; $parameters['bridge_uuid'] = $bridge_uuid; $database = new database; - $row = $database->select($sql, $parameters, 'row'); - if (is_array($row) && sizeof($row) != 0) { + $row = $database->select($sql, $parameters ?? null, 'row'); + if (!empty($row)) { $bridge_name = $row["bridge_name"]; $bridge_destination = $row["bridge_destination"]; $bridge_enabled = $row["bridge_enabled"]; @@ -199,7 +206,7 @@ echo " ".$text['label-bridge_name']."\n"; echo "\n"; echo "
| \n"; - echo " \n"; + echo " \n"; echo " | \n"; } - if ($_GET['show'] == "all" && permission_exists('conference_center_all')) { + if ($show == "all" && permission_exists('conference_center_all')) { echo th_order_by('domain_name', $text['label-domain'], $order_by, $order, $param, "class='shrink'"); } echo th_order_by('conference_center_name', $text['label-conference_center_name'], $order_by, $order); @@ -204,12 +210,12 @@ echo th_order_by('conference_center_pin_length', $text['label-conference_center_pin_length'], $order_by, $order, null, "class='center shrink'"); echo th_order_by('conference_center_enabled', $text['label-conference_center_enabled'], $order_by, $order, null, "class='center'"); echo th_order_by('conference_center_description', $text['label-conference_center_description'], $order_by, $order, null, "class='hide-sm-dn'"); - if (permission_exists('conference_center_edit') && $_SESSION['theme']['list_row_edit_button']['boolean'] == 'true') { + if (permission_exists('conference_center_edit') && $list_row_edit_button == 'true') { echo "\n"; } echo " | "; echo button::create(['type'=>'button','title'=>$text['button-edit'],'icon'=>$_SESSION['theme']['button_icon_edit'],'link'=>$list_row_url]); echo " | \n"; diff --git a/app/number_translations/number_translation_edit.php b/app/number_translations/number_translation_edit.php index 4dfdee7f42..fd68e36bcd 100644 --- a/app/number_translations/number_translation_edit.php +++ b/app/number_translations/number_translation_edit.php @@ -54,7 +54,7 @@ } //get http post variables and set them to php variables - if (is_array($_POST) && @sizeof($_POST) != 0) { + if (!empty($_POST)) { $number_translation_name = $_POST["number_translation_name"]; $number_translation_details = $_POST["number_translation_details"]; $number_translation_enabled = $_POST["number_translation_enabled"] ?: 'false'; @@ -108,7 +108,7 @@ } //redirect the user - if (in_array($_POST['action'], array('copy', 'delete', 'toggle'))) { + if (!empty($_POST['action'], array('copy', 'delete', 'toggle'))) { header('Location: number_translation_edit.php?id='.$number_translation_uuid); exit; } @@ -158,7 +158,7 @@ $database->save($array); //redirect the user - if (isset($action)) { + if (!empty($action)) { if ($action == "add") { $_SESSION["message"] = $text['message-add']; } @@ -193,12 +193,12 @@ $sql .= "order by number_translation_detail_order asc"; $parameters['number_translation_uuid'] = $number_translation_uuid; $database = new database; - $number_translation_details = $database->select($sql, $parameters, 'all'); + $number_translation_details = $database->select($sql, $parameters ?? null, 'all'); unset ($sql, $parameters); } //add an empty row - if (is_array($number_translation_details) && @sizeof($number_translation_details) != 0) { + if (!empty($number_translation_details)) { $x = count($number_translation_details); } else { @@ -275,7 +275,7 @@ echo "".$text['label-number_translation_detail_regex']." | \n"; echo "".$text['label-number_translation_detail_replace']." | \n"; echo "".$text['label-number_translation_detail_order']." | \n"; - if (is_array($number_translation_details) && @sizeof($number_translation_details) > 1 && permission_exists('number_translation_detail_delete')) { + if (!empty($number_translation_details) && @sizeof($number_translation_details) > 1 && permission_exists('number_translation_detail_delete')) { echo "\n"; echo " ".$text['label-action']."\n"; echo " \n"; diff --git a/app/number_translations/number_translations.php b/app/number_translations/number_translations.php index 586e6db140..60321966cf 100644 --- a/app/number_translations/number_translations.php +++ b/app/number_translations/number_translations.php @@ -127,7 +127,7 @@ $sql .= ") "; } $database = new database; - $num_rows = $database->select($sql, $parameters ?? '', 'column'); + $num_rows = $database->select($sql, $parameters ?? null, 'column'); //prepare to page the results $rows_per_page = (!empty($_SESSION['domain']['paging']['numeric'])) ? $_SESSION['domain']['paging']['numeric'] : 50; @@ -153,7 +153,7 @@ $sql .= order_by($order_by, $order, 'number_translation_name', 'asc'); $sql .= limit_offset($rows_per_page, $offset); $database = new database; - $number_translations = $database->select($sql, $parameters ?? '', 'all'); + $number_translations = $database->select($sql, $parameters ?? null, 'all'); unset($sql, $parameters); //create token diff --git a/app/settings/setting_edit.php b/app/settings/setting_edit.php index 4caab2669c..dc6c58973c 100644 --- a/app/settings/setting_edit.php +++ b/app/settings/setting_edit.php @@ -49,13 +49,13 @@ //get the number of rows in v_extensions $sql = " select count(*) from v_settings "; $database = new database; - $num_rows = $database->select($sql, $parameters ?? '', 'column'); + $num_rows = $database->select($sql, $parameters ?? null, 'column'); //set the action $action = $num_rows == 0 ? "add" : "update"; //get the http values and set them as php variables - if (count($_POST)>0) { + if (!empty($_POST)) { //$numbering_plan = $_POST["numbering_plan"]; //$default_gateway = $_POST["default_gateway"]; $setting_uuid = $_POST["setting_uuid"]; @@ -73,7 +73,7 @@ $mod_shout_volume = $_POST["mod_shout_volume"]; } -if (count($_POST)>0 && empty($_POST["persistformvar"])) { +if (!empty($_POST) && empty($_POST["persistformvar"])) { //check for all required data $msg = ''; diff --git a/core/default_settings/default_setting_edit.php b/core/default_settings/default_setting_edit.php index bcf68a2129..38651705ab 100644 --- a/core/default_settings/default_setting_edit.php +++ b/core/default_settings/default_setting_edit.php @@ -86,7 +86,7 @@ //build the query string $query_string = ''; - if ($search != '') { + if (!empty($search)) { $query_string .= 'search='.urlencode($search); } if ($default_setting_category != '') { @@ -95,7 +95,7 @@ } //process the http post - if (count($_POST) > 0 && empty($_POST["persistformvar"])) { + if (!empty($_POST) && empty($_POST["persistformvar"])) { //set the default_setting_uuid if ($action == "update") { diff --git a/core/default_settings/default_settings.php b/core/default_settings/default_settings.php index 313209e221..f18d3f8fe8 100644 --- a/core/default_settings/default_settings.php +++ b/core/default_settings/default_settings.php @@ -113,7 +113,7 @@ //get the count $sql = "select count(default_setting_uuid) from v_default_settings "; - if (!empty($search) && !empty($search)) { + if (!empty($search)) { $sql .= "where ("; $sql .= " lower(default_setting_category) like :search "; $sql .= " or lower(default_setting_subcategory) like :search "; @@ -135,7 +135,7 @@ $sql = "select default_setting_uuid, default_setting_category, default_setting_subcategory, default_setting_name, "; $sql .= "default_setting_value, cast(default_setting_enabled as text), default_setting_description "; $sql .= "from v_default_settings "; - if (!empty($search) && !empty($search)) { + if (!empty($search)) { $sql .= "where ("; $sql .= " lower(default_setting_category) like :search "; $sql .= " or lower(default_setting_subcategory) like :search "; |
|---|