Remove a redundant check and change from text to boolean.

This commit is contained in:
Mark Crane 2012-12-19 21:02:22 +00:00
parent d92ba11967
commit 4fbd84febf
1 changed files with 15 additions and 17 deletions

View File

@ -79,24 +79,22 @@ session_start();
$username = check_str($_REQUEST["username"]); $username = check_str($_REQUEST["username"]);
//ldap authentication //ldap authentication
if ($_SESSION["ldap"]["authentication"]["text"] == "true") { if ($_SESSION["ldap"]["authentication"]["boolean"] == "true") {
//use ldap to validate the user credentials //use ldap to validate the user credentials
if ($_SESSION["ldap"]["authentication"]["text"] == "true") { if (strlen(check_str($_REQUEST["domain_name"])) > 0) {
if (strlen(check_str($_REQUEST["domain_name"])) > 0) { $domain_name = check_str($_REQUEST["domain_name"]);
$domain_name = check_str($_REQUEST["domain_name"]); }
} $ad = ldap_connect("ldap://".$_SESSION["ldap"]["server_host"]["text"].":".$_SESSION["ldap"]["server_port"]["numeric"])
$ad = ldap_connect("ldap://".$_SESSION["ldap"]["server_host"]["text"].":".$_SESSION["ldap"]["server_port"]["numeric"]) or die("Couldn't connect to AD!");
or die("Couldn't connect to AD!"); ldap_set_option($ad, LDAP_OPT_PROTOCOL_VERSION, 3);
ldap_set_option($ad, LDAP_OPT_PROTOCOL_VERSION, 3); $bd = ldap_bind($ad,$username."@".$domain_name,check_str($_REQUEST["password"]));
$bd = ldap_bind($ad,$username."@".$domain_name,check_str($_REQUEST["password"])); if ($bd) {
if ($bd) { //echo "success\n";
//echo "success\n"; $auth_failed = false;
$auth_failed = false; }
} else {
else { //echo "failed\n";
//echo "failed\n"; $auth_failed = true;
$auth_failed = true;
}
} }
//check to see if the user exists //check to see if the user exists