diff --git a/core/dashboard/dashboard_edit.php b/core/dashboard/dashboard_edit.php
index 35f79d3fd2..dee463b1a6 100644
--- a/core/dashboard/dashboard_edit.php
+++ b/core/dashboard/dashboard_edit.php
@@ -444,16 +444,6 @@
$dashboard_detail_background_color = json_decode($dashboard_detail_background_color, true);
}
-//add a default value to $dashboard_details_state
- if (!isset($dashboard_details_state)) {
- $dashboard_details_state = "expanded";
- }
-
-//add a default value to $dashboard_row_span
- if (empty($dashboard_row_span)) {
- $dashboard_row_span = 2;
- }
-
//add an empty row
$x = is_array($dashboard_groups) ? count($dashboard_groups) : 0;
$dashboard_groups[$x]['dashboard_uuid'] = $dashboard_uuid;
@@ -810,32 +800,20 @@
echo "\n";
echo "\n";
- if ($dashboard_path == "voicemails/voicemails" ||
- $dashboard_path == "xml_cdr/missed_calls" ||
- $dashboard_path == "xml_cdr/recent_calls" ||
- $dashboard_path == "system/system_status" ||
- $dashboard_path == "system/system_cpu_status" ||
- $dashboard_path == "system/system_disk_usage" ||
- $dashboard_path == "system/system_counts" ||
- $dashboard_path == "switch/switch_status" ||
- $dashboard_path == "domain_limits/domain_limits" ||
- $dashboard_path == "call_forward/call_forward" ||
- $dashboard_path == "ring_groups/ring_group_forward" ||
- $dashboard_path == "registrations/registrations" ||
- $dashboard_path == "domains/domains" ||
- $dashboard_path == "extensions/caller_id" ||
- $dashboard_path == "maintenance/maintenance") {
- echo "
\n";
+ if (!empty($dashboard_chart_type)) {
+ echo "
\n";
echo "| \n";
echo $text['label-dashboard_chart_type']."\n";
echo " | \n";
echo "\n";
echo " \n";
echo " \n";
@@ -915,7 +893,7 @@
echo " |
\n";
}
- if ($dashboard_path != "dashboard/icon") {
+ if (!empty($dashboard_chart_type)) {
echo "\n";
echo "| \n";
echo $text['label-dashboard_number_text_color']."\n";
@@ -926,8 +904,10 @@
echo $text['description-dashboard_number_text_color']."\n";
echo " | \n";
echo "
\n";
+ }
- echo "\n";
+ if ($dashboard_chart_type == "icon" || in_array($dashboard_path, ['domains/domains', 'xml_cdr/missed_calls', 'voicemails/voicemails', 'xml_cdr/recent_calls', 'registrations/registrations'])) {
+ echo "
\n";
echo "| \n";
echo $text['label-dashboard_number_text_color_hover']."\n";
echo " | \n";
@@ -937,10 +917,8 @@
echo $text['description-dashboard_number_text_color_hover']."\n";
echo "\n";
echo "
\n";
- }
- if ($dashboard_chart_type == "icon") {
- echo "\n";
+ echo "
\n";
echo "| \n";
echo $text['label-dashboard_number_background_color']."\n";
echo " | \n";
@@ -972,11 +950,14 @@
}
}
if (empty($dashboard_background_color) || (is_array($dashboard_background_color) && count($dashboard_background_color) < 2)) {
- echo " \n";
+ echo " \n";
if (empty($dashboard_background_color)) {
echo " \n";
}
- echo "
\n";
+ }
+ if (!empty($dashboard_background_color) && !is_array($dashboard_background_color)) {
+ echo "
\n";
+ echo "
\n";
}
echo $text['description-dashboard_background_color']."\n";
echo "\n";
@@ -1003,46 +984,54 @@
}
}
if (empty($dashboard_background_color_hover) || (is_array($dashboard_background_color_hover) && count($dashboard_background_color_hover) < 2)) {
- echo " \n";
+ echo " \n";
if (empty($dashboard_background_color_hover)) {
echo " \n";
}
- echo "
\n";
+ }
+ if (!empty($dashboard_background_color_hover) && !is_array($dashboard_background_color_hover)) {
+ echo "
\n";
+ echo "
\n";
}
echo $text['description-dashboard_background_color_hover']."\n";
echo "\n";
echo "
\n";
}
- echo "\n";
- echo "| \n";
- echo $text['label-dashboard_detail_background_color']."\n";
- echo " | \n";
- echo "\n";
- if (!empty($dashboard_detail_background_color) && is_array($dashboard_detail_background_color)) {
- foreach ($dashboard_detail_background_color as $c => $detail_background_color) {
- echo " \n";
- if ($c < sizeof($dashboard_detail_background_color) - 1) { echo " \n"; }
+ if ($dashboard_details_state != "none") {
+ echo " |
\n";
+ echo "| \n";
+ echo $text['label-dashboard_detail_background_color']."\n";
+ echo " | \n";
+ echo "\n";
+ if (!empty($dashboard_detail_background_color) && is_array($dashboard_detail_background_color)) {
+ foreach ($dashboard_detail_background_color as $c => $detail_background_color) {
+ echo " \n";
+ if ($c < sizeof($dashboard_detail_background_color) - 1) { echo " \n"; }
+ }
+ //swap button
+ if (!empty($dashboard_detail_background_color) && is_array($dashboard_detail_background_color) && sizeof($dashboard_detail_background_color) > 1) {
+ echo " \n";
+ echo button::create(['type'=>'button','title'=>$text['button-swap'],'icon'=>'fa-solid fa-arrow-right-arrow-left fa-rotate-90','style'=>"z-index: 0; position: absolute; display: inline-block; margin: -14px 0 0 7px;",'onclick'=>"document.getElementById('dashboard_detail_background_color_temp').value = document.getElementById('dashboard_detail_background_color_0').value; document.getElementById('dashboard_detail_background_color_0').value = document.getElementById('dashboard_detail_background_color_1').value; document.getElementById('dashboard_detail_background_color_1').value = document.getElementById('dashboard_detail_background_color_temp').value; this.blur();"])." \n";
+ }
+ else {
+ echo " \n";
+ }
}
- //swap button
- if (!empty($dashboard_detail_background_color) && is_array($dashboard_detail_background_color) && sizeof($dashboard_detail_background_color) > 1) {
- echo " \n";
- echo button::create(['type'=>'button','title'=>$text['button-swap'],'icon'=>'fa-solid fa-arrow-right-arrow-left fa-rotate-90','style'=>"z-index: 0; position: absolute; display: inline-block; margin: -14px 0 0 7px;",'onclick'=>"document.getElementById('dashboard_detail_background_color_temp').value = document.getElementById('dashboard_detail_background_color_0').value; document.getElementById('dashboard_detail_background_color_0').value = document.getElementById('dashboard_detail_background_color_1').value; document.getElementById('dashboard_detail_background_color_1').value = document.getElementById('dashboard_detail_background_color_temp').value; this.blur();"])." \n";
+ if (empty($dashboard_detail_background_color) || (is_array($dashboard_detail_background_color) && count($dashboard_detail_background_color) < 2)) {
+ echo " \n";
+ if (empty($dashboard_detail_background_color)) {
+ echo " \n";
+ }
}
- else {
- echo " \n";
+ if (!empty($dashboard_detail_background_color) && !is_array($dashboard_detail_background_color)) {
+ echo " \n";
+ echo " \n";
}
+ echo $text['description-dashboard_detail_background_color']."\n";
+ echo " | \n";
+ echo "
\n";
}
- if (empty($dashboard_detail_background_color) || (is_array($dashboard_detail_background_color) && count($dashboard_detail_background_color) < 2)) {
- echo " \n";
- if (empty($dashboard_detail_background_color)) {
- echo " \n";
- }
- echo "
\n";
- }
- echo $text['description-dashboard_detail_background_color']."\n";
- echo "\n";
- echo "\n";
echo "\n";
echo "| \n";
@@ -1111,21 +1100,23 @@
echo " | \n";
echo "
\n";
- echo "\n";
- echo "| \n";
- echo " ".$text['label-dashboard_details_state']."\n";
- echo " | \n";
- echo "\n";
- echo " \n";
- echo " \n";
- echo $text['description-dashboard_details_state']."\n";
- echo " | \n";
- echo "
\n";
+ if ($dashboard_details_state != "none") {
+ echo "\n";
+ echo "| \n";
+ echo " ".$text['label-dashboard_details_state']."\n";
+ echo " | \n";
+ echo "\n";
+ echo " \n";
+ echo " \n";
+ echo $text['description-dashboard_details_state']."\n";
+ echo " | \n";
+ echo "
\n";
+ }
if (permission_exists('dashboard_parent_uuid')) {
echo " ";