From 5ccd29f20ff56b5dddda21e8c5116cc8df5e5a02 Mon Sep 17 00:00:00 2001 From: demonspork Date: Thu, 15 Dec 2022 19:29:46 -0600 Subject: [PATCH] Add : colon to menu item links to fix external links (#6508) --- core/menu/menu_item_edit.php | 2 +- resources/classes/menu.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/core/menu/menu_item_edit.php b/core/menu/menu_item_edit.php index c6e94b23d1..37a866d535 100644 --- a/core/menu/menu_item_edit.php +++ b/core/menu/menu_item_edit.php @@ -91,7 +91,7 @@ } //sanitize the menu link - $menu_item_link = preg_replace('#[^a-zA-Z0-9_\-\.\&\=\?\/]#', '', $menu_item_link); + $menu_item_link = preg_replace('#[^a-zA-Z0-9_:\-\.\&\=\?\/]#', '', $menu_item_link); //when a HTTP POST is available then process it if (count($_POST) > 0 && strlen($_POST["persistformvar"]) == 0) { diff --git a/resources/classes/menu.php b/resources/classes/menu.php index 079a552684..dccbe46353 100644 --- a/resources/classes/menu.php +++ b/resources/classes/menu.php @@ -421,7 +421,7 @@ if (!class_exists('menu')) { $menu_item_description = $menu['desc']; //sanitize the menu link - $menu_item_path = preg_replace('#[^a-zA-Z0-9_\-\.\&\=\?\/]#', '', $menu_item_path); + $menu_item_path = preg_replace('#[^a-zA-Z0-9_:\-\.\&\=\?\/]#', '', $menu_item_path); //check if the menu item exists and if it does set the row array $menu_item_exists = false;