From 6f2a8df1688b3973b3cb43f6e88fde4dabcc67a3 Mon Sep 17 00:00:00 2001
From: FusionPBX <markjcrane@gmail.com>
Date: Thu, 22 Sep 2022 11:23:51 -0600
Subject: [PATCH] Update FusionPBX version only when changed.

---
 core/software/app_defaults.php | 50 ++++++++++++++++++----------------
 1 file changed, 27 insertions(+), 23 deletions(-)

diff --git a/core/software/app_defaults.php b/core/software/app_defaults.php
index 1fcd518a33..32d2b0dba3 100644
--- a/core/software/app_defaults.php
+++ b/core/software/app_defaults.php
@@ -26,38 +26,42 @@
 
 if ($domains_processed == 1) {
 
+	//unset array if it exists
+		if (isset($array)) { unset($array); }
+
 	//update the software table
-		$sql = "select count(*) from v_software ";
+		$sql = "select software_version from v_software ";
 		$database = new database;
-		$num_rows = $database->select($sql, null, 'column');
-		if ($num_rows == 0) {
-			if ($array['software'][0]['software_version'] != software::version()) {
-				$array['software'][0]['software_uuid'] = '7de057e7-333b-4ebf-9466-315ae7d44efd';
-				$array['software'][0]['software_name'] = 'FusionPBX';
-				$array['software'][0]['software_url'] = 'https://www.fusionpbx.com';
-				$array['software'][0]['software_version'] = software::version();
-			}
+		$software_version = $database->select($sql, null, 'column');
+		if ($software_version == '') {
+			$array['software'][0]['software_uuid'] = '7de057e7-333b-4ebf-9466-315ae7d44efd';
+			$array['software'][0]['software_name'] = 'FusionPBX';
+			$array['software'][0]['software_url'] = 'https://www.fusionpbx.com';
+			$array['software'][0]['software_version'] = software::version();
 		}
-		else {
+		elseif ($software_version != software::version()) {
 			$array['software'][0]['software_uuid'] = '7de057e7-333b-4ebf-9466-315ae7d44efd';
 			$array['software'][0]['software_version'] = software::version();
 		}
 
-		//add the temporary permission
-		$p = new permissions;
-		$p->add("software_add", 'temp');
-		$p->add("software_edit", 'temp');
+	//save the data in the array
+		if (is_array($array) && count($array) > 0) {
+			//add the temporary permission
+			$p = new permissions;
+			$p->add("software_add", 'temp');
+			$p->add("software_edit", 'temp');
 
-		//save the data
-		$database = new database;
-		$database->app_name = 'software';
-		$database->app_uuid = 'b88c795f-7dea-4fc8-9ab7-edd555242cff';
-		$database->save($array, false);
-		unset($array);
+			//save the data
+			$database = new database;
+			$database->app_name = 'software';
+			$database->app_uuid = 'b88c795f-7dea-4fc8-9ab7-edd555242cff';
+			$database->save($array, false);
+			unset($array);
 
-		//remove the temporary permission
-		$p->delete("software_add", 'temp');
-		$p->delete("software_edit", 'temp');
+			//remove the temporary permission
+			$p->delete("software_add", 'temp');
+			$p->delete("software_edit", 'temp');
+		}
 
 }