dbxe
/
fusionpbx
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix xml_cdr import failing to move a zero byte record to failed folder (#7210) 

When an XML CDR record is zero bytes that is recorded in the /var/log/freeswitch/xml_cdr directory, the xml_cdr class would fail to move the file. This causes the record files to eventually build up to where the files can exceed the import limit. This adjustment moves the sanity checking for `filesize` to before the import attempt and checks for over limit and zero bytes. If those conditions match the file is moved to the "failed" folder.
This commit is contained in:
frytimo 2025-01-09 14:47:28 -04:00 committed by GitHub
parent f121c16931
commit 79b0767343
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 16 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
app/xml_cdr/resources/classes/xml_cdr.php
View File

@ -1552,8 +1552,23 @@ if (!class_exists('xml_cdr')) {
$import = true;
}
//move the files that are too large or zero file size to the failed directory
if ($import && (filesize($xml_cdr_dir.'/'.$file) >= 3000000 || filesize($xml_cdr_dir.'/'.$file) == 0)) {
//echo "WARNING: File too large or zero file size. Moving $file to failed\n";
if (!empty($xml_cdr_dir)) {
if (!file_exists($xml_cdr_dir.'/failed')) {
if (!mkdir($xml_cdr_dir.'/failed', 0660, true)) {
die('Failed to create '.$xml_cdr_dir.'/failed');
}
}
if (rename($xml_cdr_dir.'/'.$file, $xml_cdr_dir.'/failed/'.$file)) {
//echo "Moved $file successfully\n";
}
}
}
//import the call detail files are less than 3 mb - 3 million bytes
if ($import && filesize($xml_cdr_dir.'/'.$file) <= 3000000) {
if ($import) {
//get the xml cdr string
$call_details = file_get_contents($xml_cdr_dir.'/'.$file);
@ -1572,18 +1587,6 @@ if (!class_exists('xml_cdr')) {
$x++;
}
//move the files that are too large to the failed directory
if ($import && filesize($xml_cdr_dir.'/'.$file) >= 3000000) {
if (!empty($xml_cdr_dir)) {
if (!file_exists($xml_cdr_dir.'/failed')) {
if (!mkdir($xml_cdr_dir.'/failed', 0660, true)) {
die('Failed to create '.$xml_cdr_dir.'/failed');
}
}
rename($xml_cdr_dir.'/'.$file, $xml_cdr_dir.'/failed/'.$file);
}
}
//if limit exceeded exit the loop
if ($limit == $x) {
//echo "limit: $limit count: $x if\n";