From a5a7a8530ae7cc35cbdcc1bfdcae611282b891e5 Mon Sep 17 00:00:00 2001 From: FusionPBX Date: Fri, 16 Aug 2024 15:10:05 -0600 Subject: [PATCH] Update voicemail.php Don't run the query if there are no assigned voicemails --- .../resources/classes/voicemail.php | 25 +++++++++++-------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/app/voicemails/resources/classes/voicemail.php b/app/voicemails/resources/classes/voicemail.php index 35c72220b8..2ec25e6aec 100644 --- a/app/voicemails/resources/classes/voicemail.php +++ b/app/voicemails/resources/classes/voicemail.php @@ -158,18 +158,21 @@ } //get the assigned voicemails - $sql = "select * from v_voicemails "; - $sql .= "where voicemail_id in ("; - foreach($voicemail_ids as $i => $voicemail_id) { - if ($i > 0) { $sql .= ","; } - $sql .= ":voicemail_id_".$i; - $parameters['voicemail_id_'.$i] = $voicemail_id; + $assigned_voicemails = []; + if (!empty($voicemail_ids) && @sizeof($voicemail_ids) != 0) { + $sql = "select * from v_voicemails "; + $sql .= "where voicemail_id in ("; + foreach($voicemail_ids as $i => $voicemail_id) { + if ($i > 0) { $sql .= ","; } + $sql .= ":voicemail_id_".$i; + $parameters['voicemail_id_'.$i] = $voicemail_id; + } + $sql .= ") "; + $sql .= "and domain_uuid = :domain_uuid "; + $parameters['domain_uuid'] = $this->domain_uuid; + $assigned_voicemails = $this->database->select($sql, $parameters, 'all'); + unset($sql, $parameters); } - $sql .= ") "; - $sql .= "and domain_uuid = :domain_uuid "; - $parameters['domain_uuid'] = $this->domain_uuid; - $assigned_voicemails = $this->database->select($sql, $parameters, 'all'); - unset($sql, $parameters); //set the voicemail uuid arrays $voicemail_uuids = [];