From a898a61d9883834b0466e9e927b96e7aeaada53b Mon Sep 17 00:00:00 2001
From: Nate <github@najo.com>
Date: Mon, 10 Feb 2020 21:11:37 -0700
Subject: [PATCH] Menu Items: Show correct count.

---
 core/menu/menu_item_list.php | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/core/menu/menu_item_list.php b/core/menu/menu_item_list.php
index 84508b2188..1d923c8fb1 100644
--- a/core/menu/menu_item_list.php
+++ b/core/menu/menu_item_list.php
@@ -220,7 +220,6 @@ function build_db_child_menu_list ($db, $menu_item_level, $menu_item_uuid) {
 	$parameters['menu_uuid'] = $menu_uuid;
 	$database = new database;
 	$result = $database->select($sql, $parameters, 'all');
-	$num_rows = is_array($result) && @sizeof($result) != 0 ? sizeof($result) : 0;
 	unset($sql, $parameters);
 
 //create token
@@ -233,7 +232,7 @@ function build_db_child_menu_list ($db, $menu_item_level, $menu_item_uuid) {
 	echo "<input type='hidden' name='menu_uuid' value='".escape($menu_uuid)."'>\n";
 
 	echo "<div class='action_bar' id='action_bar_sub'>\n";
-	echo "	<div class='heading'><b id='heading_sub'>".$text['header-menu_items']." (".$num_rows.")</b></div>\n";
+	echo "	<div class='heading'><b id='heading_sub'>".$text['header-menu_items']." (<span id='num_rows'></span>)</b></div>\n";
 	echo "	<div class='actions'>\n";
 	echo button::create(['type'=>'button','id'=>'action_bar_sub_button_back','label'=>$text['button-back'],'icon'=>$_SESSION['theme']['button_icon_back'],'collapse'=>'hide-xs','style'=>'margin-right: 15px; display: none;','link'=>'menu.php']);
 	if (permission_exists('menu_item_add')) {
@@ -414,6 +413,9 @@ function build_db_child_menu_list ($db, $menu_item_level, $menu_item_uuid) {
 	echo "		document.getElementById('action_bar_sub_button_back').style.display = 'none';\n";
 	echo "	}\n";
 
+//update number of menu items
+	echo "	document.getElementById('num_rows').innerHTML = '".$x."';\n";
+
 	echo "</script>\n";
 
 ?>
\ No newline at end of file