dbxe/fusionpbx
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixes PHP fatal error when editing users (#6700)

Browse Source 
* Update user_edit.php

Some PHP implementations return a fatal error when in_array() has the second parameter null.

 $_SESSION['authentication']['methods']  is null by default on new installations.
This commit is contained in:
Luis Daniel Lucio Quiroz
2023-05-24 17:27:06 -06:00
committed by GitHub
parent 3b8b771c92
commit af101bcd7b
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
core/users/user_edit.php
+3 -3
View File
@@ -145,7 +145,7 @@
if (permission_exists('message_key')) { if (permission_exists('message_key')) {
$message_key = $_POST["message_key"]; $message_key = $_POST["message_key"];
} }
if (isset($_SESSION['authentication']['methods']) && in_array('totp', $_SESSION['authentication']['methods'])) { if (is_array($_SESSION['authentication']['methods']) && (in_array('totp', $_SESSION['authentication']['methods']))) {
$user_totp_secret = strtoupper($_POST["user_totp_secret"]); $user_totp_secret = strtoupper($_POST["user_totp_secret"]);
} }
@@ -527,7 +527,7 @@
if (permission_exists('api_key')) { if (permission_exists('api_key')) {
$array['users'][$x]['api_key'] = ($api_key != '') ? $api_key : null; $array['users'][$x]['api_key'] = ($api_key != '') ? $api_key : null;
} }
if (in_array('totp', $_SESSION['authentication']['methods'])) { if (is_array($_SESSION['authentication']['methods']) && (in_array('totp', $_SESSION['authentication']['methods']))) {
$array['users'][$x]['user_totp_secret'] = $user_totp_secret; $array['users'][$x]['user_totp_secret'] = $user_totp_secret;
} }
$array['users'][$x]['user_enabled'] = $user_enabled; $array['users'][$x]['user_enabled'] = $user_enabled;
@@ -1094,7 +1094,7 @@
} }
//user time based one time password secret //user time based one time password secret
if (in_array('totp', $_SESSION['authentication']['methods'])) { if (is_array($_SESSION['authentication']['methods']) && (in_array('totp', $_SESSION['authentication']['methods']))) {
if ($user_totp_secret != '' && $username != '') { if ($user_totp_secret != '' && $username != '') {
$otpauth = "otpauth://totp/".$username."?secret=".$user_totp_secret."&issuer=".$_SESSION['domain_name']; $otpauth = "otpauth://totp/".$username."?secret=".$user_totp_secret."&issuer=".$_SESSION['domain_name'];