From b14e8f20c8a25440c224f8ade9de7342eaa3477e Mon Sep 17 00:00:00 2001
From: Tim Fry <tim@fusionpbx.com>
Date: Mon, 2 Dec 2024 17:33:52 -0400
Subject: [PATCH] use labels

---
 app/phrases/phrase_edit.php                   |  4 +++-
 .../resources/javascript/phrase_edit.js       | 23 +++++++++++++++++--
 2 files changed, 24 insertions(+), 3 deletions(-)

diff --git a/app/phrases/phrase_edit.php b/app/phrases/phrase_edit.php
index f6ff005a09..7920aab996 100644
--- a/app/phrases/phrase_edit.php
+++ b/app/phrases/phrase_edit.php
@@ -342,7 +342,9 @@ if (count($_POST) > 0) {
 
 //javascript constants for use in the selection option group
 	echo "<script>\n";
-	echo "window.phrase_commands = " . json_encode(['Play', 'Pause', 'Execute'], true) . ";\n";
+	echo "window.phrase_label_sounds = '" . ($text['label-sounds'] ?? 'Sounds') . "';\n";
+	echo "window.phrase_label_recordings = '" . ($text['label-recordings'] ?? 'Recordings') . "';\n";
+	echo "window.phrase_commands = " . json_encode([$text['label-play'] ?? 'Play', $text['label-pause'] ?? 'Pause', $text['label-execute'] ?? 'Execute'], true) . ";\n";
 
 	//existing details
 	if (!empty($phrase_details)) {
diff --git a/app/phrases/resources/javascript/phrase_edit.js b/app/phrases/resources/javascript/phrase_edit.js
index 537489bc15..1eafa8ee2f 100644
--- a/app/phrases/resources/javascript/phrase_edit.js
+++ b/app/phrases/resources/javascript/phrase_edit.js
@@ -8,14 +8,14 @@ document.addEventListener("DOMContentLoaded", function () {
 	select.appendChild(new Option('', ''));
 
 	// Add recordings
-	grp_rec.label = 'Recordings';
+	grp_rec.label = window.phrase_label_recordings;
 	for (let i = 0; i < window.phrase_recordings.length; i++) {
 		grp_rec.appendChild(new Option(window.phrase_recordings[i].recording_name, window.phrase_recordings[i].recording_uuid));
 	}
 	select.appendChild(grp_rec);
 
 	// Add sounds
-	grp_snd.label = 'Sounds';
+	grp_snd.label = window.phrase_label_sounds;
 	for (let i = 0; i < window.phrase_sounds.length; i++) {
 		grp_snd.appendChild(new Option(window.phrase_sounds[i], window.phrase_sounds[i]));
 	}
@@ -31,7 +31,9 @@ document.addEventListener("DOMContentLoaded", function () {
 	add_draggable_rows();
 });
 
+//
 // Inserts all existing records before the empty one
+//
 function add_existing() {
 	const tbody = document.getElementById('structure');
 
@@ -62,6 +64,9 @@ function add_existing() {
 	}
 }
 
+//
+// Set the selected index on a dropdown box based on the value (key)
+//
 function select_by_value(selectElement, valueToFind) {
     // Loop through the options of the select element
     for (let i = 0; i < selectElement.options.length; i++) {
@@ -73,6 +78,9 @@ function select_by_value(selectElement, valueToFind) {
     console.warn('Value not found in select options');
 }
 
+//
+// Set the selected index on a dropdown box based on the text
+//
 function select_by_text(selectElement, textToFind) {
     for (let i = 0; i < selectElement.options.length; i++) {
         if (selectElement.options[i].text === textToFind) {
@@ -83,7 +91,9 @@ function select_by_text(selectElement, textToFind) {
     console.warn('Text not found in select options');
 }
 
+//
 // Add draggable functionality to rows
+//
 function add_draggable_rows() {
 	const tableBody = document.getElementById('structure');
 	let draggedRow = null;
@@ -115,7 +125,9 @@ function add_draggable_rows() {
 
 }
 
+//
 // Function to update the 'name' attribute based on row numbers
+//
 function update_order() {
 	const tableBody = document.getElementById('structure');
 	const rows = tableBody.querySelectorAll('tr');
@@ -144,6 +156,9 @@ function update_order() {
 	});
 }
 
+//
+// Ensure the order is updated when submitting the form
+//
 function submit_phrase() {
 	//ensure order is updated before submitting form
 	update_order();
@@ -151,7 +166,9 @@ function submit_phrase() {
 	const form = document.getElementById('frm').submit();
 }
 
+//
 // Add a new row to the table
+//
 function add_row() {
 	const tbody = document.getElementById('structure');
 	const newRow = document.getElementById('empty_row').cloneNode(true);
@@ -175,7 +192,9 @@ function add_row() {
 	add_draggable_rows();
 }
 
+//
 // Remove the last row in the table
+//
 function remove_row() {
 	const tbody = document.getElementById('structure');
 	if (tbody && tbody.rows.length > 1) {