From e460c4f180cc2922fba01d9fe2d7ca6583094742 Mon Sep 17 00:00:00 2001 From: fusionate Date: Thu, 20 Mar 2025 17:26:42 -0600 Subject: [PATCH] Access Control - Edit: Remove unintended single-quotes when dig domain used as Description. --- app/access_controls/access_control_edit.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/access_controls/access_control_edit.php b/app/access_controls/access_control_edit.php index 43de3ee8bf..352591d01e 100644 --- a/app/access_controls/access_control_edit.php +++ b/app/access_controls/access_control_edit.php @@ -190,7 +190,7 @@ else { $digs[] = [ 'type'=>$row['node_type'], - 'value'=>escapeshellarg(str_replace(' ', '', $row['node_cidr'])), + 'value'=>$row['node_cidr'], 'description'=>$row['node_description'], ]; } @@ -202,7 +202,7 @@ //attempt digs if (!empty($digs) && is_array($digs)) { foreach ($digs as $dig) { - $response = shell_exec("dig +noall +answer ".$dig['value']." | awk '{ print $5 }'"); + $response = shell_exec("dig +noall +answer ".escapeshellarg(str_replace(' ', '', $dig['value']))." | awk '{ print $5 }'"); if (!empty($response)) { $lines = explode("\n", $response); foreach ($lines as $l => $line) { @@ -217,7 +217,7 @@ $array['access_controls'][0]['access_control_nodes'][$y]['access_control_node_uuid'] = uuid(); $array['access_controls'][0]['access_control_nodes'][$y]['node_type'] = $dig['type']; $array['access_controls'][0]['access_control_nodes'][$y]['node_cidr'] = $line.'/32'; - $array['access_controls'][0]['access_control_nodes'][$y]['node_description'] = !empty($dig['description']) ? $dig['description'] : $dig['value']; + $array['access_controls'][0]['access_control_nodes'][$y]['node_description'] = !empty($dig['description']) ? $dig['description'] : str_replace(' ', '', $dig['value']); $y++; } }