dbxe
/
fusionpbx
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update orm.php 

Make this code more resilient in case the primary key or sub table primary key was provided in the data.
This commit is contained in:
FusionPBX 2016-07-14 01:06:04 -06:00 committed by GitHub
parent bbe1705019
commit f806e0297c
1 changed files with 158 additions and 61 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

219
resources/classes/orm.php
View File

@ -17,7 +17,7 @@
The Initial Developer of the Original Code is The Initial Developer of the Original Code is
Mark J Crane <markjcrane@fusionpbx.com> Mark J Crane <markjcrane@fusionpbx.com>
Copyright (C) 2014 Copyright (C) 2014-2016
All Rights Reserved. All Rights Reserved.
Contributor(s): Contributor(s):
@ -264,7 +264,12 @@
$table_name = "v_".$this->name; $table_name = "v_".$this->name;
$parent_key_name = $this->singular($this->name)."_uuid"; $parent_key_name = $this->singular($this->name)."_uuid";
//get the number of rows //set the uuid
if (isset($array[$parent_key_name])) {
$this->uuid = $array[$parent_key_name];
}
//determine action update or delete
if (isset($this->uuid)) { if (isset($this->uuid)) {
$sql = "SELECT count(*) AS num_rows FROM ".$table_name." "; $sql = "SELECT count(*) AS num_rows FROM ".$table_name." ";
$sql .= "WHERE ".$parent_key_name." = '".$this->uuid."' "; $sql .= "WHERE ".$parent_key_name." = '".$this->uuid."' ";
@ -276,7 +281,32 @@
$action = "update"; $action = "update";
} }
else { else {
//set the action
$action = "add"; $action = "add";
//unset the primary key if it doesn't exist
unset($array[$parent_key_name]);
unset($this->uuid);
//remove parent and child keys from the data if the parent key doesn't exist
foreach ($array as $key => $value) {
if (is_array($value)) {
$child_key_name = $this->singular($key)."_uuid";
$i = 0;
foreach ($value as $row) {
foreach ($row as $k => $v) {
if ($k == $parent_key_name) {
unset($array[$key][$i][$parent_key_name]);
}
if ($k == $child_key_name) {
unset($array[$key][$i][$child_key_name]);
}
}
$i++;
}
}
}
} }
} }
unset($prep_statement); unset($prep_statement);
@ -284,15 +314,28 @@
else { else {
$action = "add"; $action = "add";
} }
/*
if ($table_name == "v_dialplans") {
echo "<pre>\n";
print_r($array);
echo "</pre>\n";
exit;
}
*/
//add a record //add a record
//set the message index //set the message index
$m = 0; $m = 0;
if ($action == "add") { if ($action == "add") {
if (permission_exists($this->singular($this->name).'_add')) { if (permission_exists($this->singular($this->name).'_add')) {
//start the atomic transaction //start the atomic transaction
$this->db->beginTransaction(); $this->db->beginTransaction();
//determine if child or parent key exists
$parent_key_exists = false;
foreach ($array as $k => $v) {
if ($k == $parent_key_name) { $parent_key_exists = true; }
}
//parent data //parent data
if (isset($this->uuid)) { if (isset($this->uuid)) {
@ -303,7 +346,9 @@
} }
$sql = "INSERT INTO v_".$this->name." "; $sql = "INSERT INTO v_".$this->name." ";
$sql .= "("; $sql .= "(";
$sql .= $parent_key_name.", "; if (!$parent_key_exists) {
$sql .= $parent_key_name.", ";
}
foreach ($array as $key => $value) { foreach ($array as $key => $value) {
if (!is_array($value)) { if (!is_array($value)) {
$sql .= check_str($key).", "; $sql .= check_str($key).", ";
@ -312,7 +357,9 @@
$sql .= ") "; $sql .= ") ";
$sql .= "VALUES "; $sql .= "VALUES ";
$sql .= "("; $sql .= "(";
$sql .= "'".$parent_key_value."', "; if (!$parent_key_exists) {
$sql .= "'".$parent_key_value."', ";
}
foreach ($array as $key => $value) { foreach ($array as $key => $value) {
if (!is_array($value)) { if (!is_array($value)) {
if (strlen($value) == 0) { if (strlen($value) == 0) {
@ -379,33 +426,48 @@
$uuid_exists = false; $uuid_exists = false;
} }
} }
//determine if child or parent key exists
$parent_key_exists = false;
$child_key_exists = false;
foreach ($row as $k => $v) {
if ($k == $parent_key_name) { $parent_key_exists = true; }
if ($k == $child_key_name) { $child_key_exists = true; }
}
//add the data //add the data
$sql = "INSERT INTO ".$table_name." "; $sql = "INSERT INTO ".$table_name." ";
$sql .= "("; $sql .= "(";
$sql .= $parent_key_name.", "; if (!$parent_key_exists) {
$sql .= $child_key_name.", "; $sql .= $parent_key_name.", ";
}
if (!$child_key_exists) {
$sql .= $child_key_name.", ";
}
foreach ($row as $k => $v) { foreach ($row as $k => $v) {
if (!is_array($v)) { if (!is_array($v)) {
if ($k != $child_key_name) { //if ($k != $child_key_name) {
$sql .= check_str($k).", "; $sql .= check_str($k).", ";
} //}
} }
} }
$sql .= ") "; $sql .= ") ";
$sql .= "VALUES "; $sql .= "VALUES ";
$sql .= "("; $sql .= "(";
$sql .= "'".$parent_key_value."', "; if (!$parent_key_exists) {
$sql .= "'".$child_key_value."', "; $sql .= "'".$parent_key_value."', ";
}
if (!$child_key_exists) {
$sql .= "'".$child_key_value."', ";
}
foreach ($row as $k => $v) { foreach ($row as $k => $v) {
if (!is_array($v)) { if (!is_array($v)) {
if ($k != $child_key_name) { //if ($k != $child_key_name) {
if (strlen($v) == 0) { if (strlen($v) == 0) {
$sql .= "null, "; $sql .= "null, ";
} }
else { else {
$sql .= "'".check_str($v)."', "; $sql .= "'".check_str($v)."', ";
} }
} //}
} }
} }
$sql .= ");"; $sql .= ");";
@ -483,9 +545,11 @@
$this->db->query(check_sql($sql)); $this->db->query(check_sql($sql));
$message["message"] = "OK"; $message["message"] = "OK";
$message["code"] = "200"; $message["code"] = "200";
$message["uuid"] = $parent_key_value;
$message["details"][$m]["name"] = $this->name; $message["details"][$m]["name"] = $this->name;
$message["details"][$m]["message"] = "OK"; $message["details"][$m]["message"] = "OK";
$message["details"][$m]["code"] = "200"; $message["details"][$m]["code"] = "200";
$message["details"][$m]["uuid"] = $parent_key_value;
if ($this->debug["sql"]) { if ($this->debug["sql"]) {
$message["details"][$m]["sql"] = $sql; $message["details"][$m]["sql"] = $sql;
} }
@ -515,7 +579,13 @@
$child_name = $this->singular($key); $child_name = $this->singular($key);
$child_key_name = $child_name."_uuid"; $child_key_name = $child_name."_uuid";
//uuid_exists true / false //determine if the parent key exists
$parent_key_exists = false;
if (!isset($array[$parent_key_name])) {
$parent_key_exists = true;
}
//determine if the uuid exists
$uuid_exists = false; $uuid_exists = false;
$child_key_value = uuid(); $child_key_value = uuid();
foreach ($row as $k => $v) { foreach ($row as $k => $v) {
@ -533,59 +603,82 @@
//update the data //update the data
if ($uuid_exists) { if ($uuid_exists) {
//if (permission_exists($child_name.'_edit')) {
$sql = "UPDATE ".$table_name." SET "; $sql = "UPDATE ".$table_name." SET ";
foreach ($row as $k => $v) { foreach ($row as $k => $v) {
if (!is_array($v) && $k != $child_key_name) { //if (!is_array($v) && $k != $child_key_name) { //original
if (strlen($v) == 0) { if (!is_array($v) && ($k != $parent_key_name || $k != $child_key_name)) {
$sql .= check_str($k)." = null, "; if (strlen($v) == 0) {
} $sql .= check_str($k)." = null, ";
else { }
$sql .= check_str($k)." = '".check_str($v)."', "; else {
} $sql .= check_str($k)." = '".check_str($v)."', ";
} }
} }
$sql .= "WHERE ".$parent_key_name." = '".$this->uuid."' "; }
$sql .= "AND ".$child_key_name." = '".$child_key_value."' "; $sql .= "WHERE ".$parent_key_name." = '".$this->uuid."' ";
$sql = str_replace(", WHERE", " WHERE", $sql); $sql .= "AND ".$child_key_name." = '".$child_key_value."' ";
$this->db->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION); $sql = str_replace(", WHERE", " WHERE", $sql);
// if (strlen($child_key_value) > 0) { $this->db->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);
try { try {
$this->db->query(check_sql($sql)); $this->db->query(check_sql($sql));
$message["details"][$m]["name"] = $key; $message["details"][$m]["name"] = $key;
$message["details"][$m]["message"] = "OK"; $message["details"][$m]["message"] = "OK";
$message["details"][$m]["code"] = "200"; $message["details"][$m]["code"] = "200";
if ($this->debug["sql"]) { $message["details"][$m]["uuid"] = $child_key_value;
$message["details"][$m]["sql"] = $sql; if ($this->debug["sql"]) {
} $message["details"][$m]["sql"] = $sql;
$this->message = $message; }
$m++; $this->message = $message;
} $m++;
catch(PDOException $e) { }
if ($message["code"] = "200") { catch(PDOException $e) {
$message["message"] = "Bad Request"; if ($message["code"] = "200") {
$message["code"] = "400"; $message["message"] = "Bad Request";
} $message["code"] = "400";
$message["details"][$m]["name"] = $key; }
$message["details"][$m]["message"] = $e->getMessage(); $message["details"][$m]["name"] = $key;
$message["details"][$m]["code"] = "400"; $message["details"][$m]["message"] = $e->getMessage();
if ($this->debug["sql"]) { $message["details"][$m]["code"] = "400";
$message["details"][$m]["sql"] = $sql; if ($this->debug["sql"]) {
} $message["details"][$m]["sql"] = $sql;
$this->message = $message; }
$m++; $this->message = $message;
} $m++;
// } }
//}
} }
//add the data //add the data
if (!$uuid_exists) { if (!$uuid_exists) {
if (permission_exists($child_name.'_add')) { if (permission_exists($child_name.'_add')) {
//determine if child or parent key exists
$child_key_name = $this->singular($child_name).'_uuid';
$child_key_exists = false;
foreach ($row as $k => $v) {
if ($k == $parent_key_name) {
$parent_key_exists = true;
$parent_key_value = $v;
}
if ($k == $child_key_name) {
$child_key_exists = true;
$child_key_value = $v;
}
}
if (!$parent_key_name) {
$parent_key_value = uuid();
}
if (!$child_key_name) {
$child_key_value = uuid();
}
//build the insert
$sql = "INSERT INTO ".$table_name." "; $sql = "INSERT INTO ".$table_name." ";
$sql .= "("; $sql .= "(";
$sql .= $this->singular($parent_key_name).", "; if (!$parent_key_exists) {
$sql .= $this->singular($child_key_name).", "; $sql .= $this->singular($parent_key_name).", ";
}
if (!$child_key_exists) {
$sql .= $this->singular($child_key_name).", ";
}
foreach ($row as $k => $v) { foreach ($row as $k => $v) {
if (!is_array($v)) { if (!is_array($v)) {
$sql .= check_str($k).", "; $sql .= check_str($k).", ";
@ -594,8 +687,12 @@
$sql .= ") "; $sql .= ") ";
$sql .= "VALUES "; $sql .= "VALUES ";
$sql .= "("; $sql .= "(";
$sql .= "'".$parent_key_value."', "; if (!$parent_key_exists) {
$sql .= "'".$child_key_value."', "; $sql .= "'".$parent_key_value."', ";
}
if (!$child_key_exists) {
$sql .= "'".$child_key_value."', ";
}
foreach ($row as $k => $v) { foreach ($row as $k => $v) {
if (!is_array($v)) { if (!is_array($v)) {
if (strlen($v) == 0) { if (strlen($v) == 0) {
@ -752,4 +849,4 @@
print_r($result); print_r($result);
*/ */
?> ?>