diff --git a/app/devices/device_edit.php b/app/devices/device_edit.php index 0d28895d1e..7b363d6013 100644 --- a/app/devices/device_edit.php +++ b/app/devices/device_edit.php @@ -381,6 +381,7 @@ require_once "resources/require.php"; $sql = "SELECT * FROM v_device_keys "; $sql .= "WHERE device_uuid = '".$device_uuid."' "; $sql .= "ORDER by "; + $sql .= "device_key_vendor asc, "; $sql .= "CASE device_key_category "; $sql .= "WHEN 'line' THEN 1 "; $sql .= "WHEN 'memory' THEN 2 "; @@ -733,24 +734,50 @@ require_once "resources/require.php"; echo " "; } - //custom keys + $vendor_count = 0; + foreach($device_keys as $row) { + if ($previous_vendor != $row['device_key_vendor']) { + $previous_vendor = $row['device_key_vendor']; + $vendor_count++; + } + } + echo " "; echo " ".$text['label-keys'].""; echo " "; echo " \n"; - echo " \n"; - echo " \n"; - echo " \n"; - echo " \n"; - echo " \n"; - echo " \n"; - echo " \n"; - echo " \n"; - echo " \n"; - echo " \n"; + if ($vendor_count == 0) { + echo " \n"; + echo " \n"; + echo " \n"; + echo " \n"; + echo " \n"; + echo " \n"; + echo " \n"; + echo " \n"; + echo " \n"; + echo " \n"; + } $x = 0; foreach($device_keys as $row) { + //set the column names + if ($previous_device_key_vendor != $row['device_key_vendor']) { + echo " \n"; + echo " \n"; + echo " \n"; + if ($vendor_count > 1 && strlen($row['device_key_vendor']) > 0) { + echo " \n"; + } else { + echo " \n"; + } + echo " \n"; + echo " \n"; + echo " \n"; + echo " \n"; + echo " \n"; + echo " \n"; + } //determine whether to hide the element if (strlen($device_key_uuid) == 0) { $element['hidden'] = false; @@ -851,7 +878,7 @@ require_once "resources/require.php"; 0) { - if (strlen($device_vendor) == 0 || strlen($device_username) > 0) { echo ""; } + echo ""; ?> @@ -861,7 +888,7 @@ require_once "resources/require.php"; if (strlen($device_vendor) == 0) { echo ""; } } if (strtolower($device_vendor) == "cisco" || strlen($device_vendor) == 0 || strlen($device_username) > 0) { - if (strlen($device_vendor) == 0 || strlen($device_username) > 0) { echo ""; } + echo ""; ?> @@ -869,7 +896,7 @@ require_once "resources/require.php"; if (strlen($device_vendor) == 0) { echo ""; } } if (strtolower($device_vendor) == "grandstream" || strlen($device_vendor) == 0 || strlen($device_username) > 0) { - if (strlen($device_vendor) == 0 || strlen($device_username) > 0) { echo ""; } + echo ""; ?> @@ -889,7 +916,7 @@ require_once "resources/require.php"; if (strlen($device_vendor) == 0) { echo ""; } } if (strtolower($device_vendor) == "polycom" || strlen($device_vendor) == 0 || strlen($device_username) > 0) { - if (strlen($device_vendor) == 0 || strlen($device_username) > 0) { echo ""; } + echo ""; ?> @@ -898,7 +925,7 @@ require_once "resources/require.php"; if (strlen($device_vendor) == 0) { echo ""; } } if (strtolower($device_vendor) == "snom" || strlen($device_vendor) == 0 || strlen($device_username) > 0) { - if (strlen($device_vendor) == 0 || strlen($device_username) > 0) { echo ""; } + echo ""; ?> @@ -926,7 +953,7 @@ require_once "resources/require.php"; if (strlen($device_vendor) == 0) { echo ""; } } if (strtolower($device_vendor) == "yealink" || strlen($device_vendor) == 0 || strlen($device_username) > 0) { - if (strlen($device_vendor) == 0 || strlen($device_username) > 0) { echo ""; } + echo ""; ?> @@ -1014,6 +1041,8 @@ require_once "resources/require.php"; } echo " \n"; echo " \n"; + //set the previous vendor + $previous_device_key_vendor = $row['device_key_vendor']; //increment the array key $x++; }
".$text['label-device_key_category']."".$text['label-device_key_id']."".$text['label-device_key_type']."".$text['label-device_key_line']."".$text['label-device_key_value']."".$text['label-device_key_extension']."".$text['label-device_key_label']." 
".$text['label-device_key_category']."".$text['label-device_key_id']."".$text['label-device_key_type']."".$text['label-device_key_line']."".$text['label-device_key_value']."".$text['label-device_key_extension']."".$text['label-device_key_label']." 
".$text['label-device_key_category']."".$text['label-device_key_id']."".ucwords($row['device_key_vendor'])."".$text['label-device_key_type']."".$text['label-device_key_line']."".$text['label-device_key_value']."".$text['label-device_key_extension']."".$text['label-device_key_label']."