diff --git a/app/contacts/contact_settings.php b/app/contacts/contact_settings.php index 462a8ecec8..5d9d42b9c9 100644 --- a/app/contacts/contact_settings.php +++ b/app/contacts/contact_settings.php @@ -17,23 +17,27 @@ The Initial Developer of the Original Code is Mark J Crane - Portions created by the Initial Developer are Copyright (C) 2008-2012 + Portions created by the Initial Developer are Copyright (C) 2008-2018 the Initial Developer. All Rights Reserved. Contributor(s): Mark J Crane Luis Daniel Lucio Quiroz */ -require_once "root.php"; -require_once "resources/require.php"; -require_once "resources/check_auth.php"; -if (permission_exists('contact_setting_view')) { - //access granted -} -else { - echo "access denied"; - exit; -} + +//includes + require_once "root.php"; + require_once "resources/require.php"; + require_once "resources/check_auth.php"; + +//check permissions + if (permission_exists('contact_setting_view')) { + //access granted + } + else { + echo "access denied"; + exit; + } //get the list $sql = "select * from v_contact_settings "; @@ -79,38 +83,38 @@ else { $previous_category = ''; foreach($result as $row) { if (permission_exists('contact_setting_edit')) { - $tr_link = " href='contact_setting_edit.php?contact_uuid=".$contact_uuid."&id=".$row['contact_setting_uuid']."'"; + $tr_link = " href='contact_setting_edit.php?contact_uuid=".$contact_uuid."&id=".escape($row['contact_setting_uuid'])."'"; } echo "\n"; - echo " ".$row['contact_setting_category']." \n"; - echo " ".$row['contact_setting_subcategory']."\n"; - echo " ".$row['contact_setting_name']." \n"; + echo " ".escape($row['contact_setting_category'])." \n"; + echo " ".escape($row['contact_setting_subcategory'])."\n"; + echo " ".escape($row['contact_setting_name'])." \n"; echo " \n"; - $category = $row['contact_setting_category']; - $subcategory = $row['contact_setting_subcategory']; - $name = $row['contact_setting_name']; + $category = escape($row['contact_setting_category']); + $subcategory = escape($row['contact_setting_subcategory']); + $name = escape($row['contact_setting_name']); if ($category == "callingcard" && $subcategory == "username" && $name == "var" ) { echo " ********  \n"; } elseif ($category == "callingcard" && $subcategory == "password" && $name == "var" ) { echo " ********  \n"; } else { - echo $row['contact_setting_value']; + echo escape($row['contact_setting_value']); } echo "  \n"; echo " \n"; - echo " ".$text['label-'.$row['contact_setting_enabled']]." \n"; + echo " ".$text['label-'.escape($row['contact_setting_enabled'])]." \n"; echo " ".$row['contact_setting_description']." \n"; echo " "; if (permission_exists('contact_setting_edit')) { - echo "$v_link_label_edit"; + echo "$v_link_label_edit"; } if (permission_exists('contact_setting_delete')) { - echo "$v_link_label_delete"; + echo "$v_link_label_delete"; } echo " \n"; echo "\n"; - $previous_category = $row['contact_setting_category']; + $previous_category = escape($row['contact_setting_category']); $c = ($c) ? 0 : 1; } //end foreach unset($sql, $result, $row_count); @@ -118,4 +122,4 @@ else { echo ""; -?> \ No newline at end of file +?>