New system use the journal (some still use syslog). the "log" action default level is DEBUG.
This change moves the 404 error code to WARNING, the mod_syslog will report to the journal (or syslog).
This SMS bugfix works out two issues:
* SMS permissions were not properly included. This causes SMS functionality to be inaccessible if the system implementor works out a Lua SMS implementation
* If voicemail transcription doesn't exist for the voicemail the send_sms.lua script crashes. Added a nil check to prevent this.
Setting ignore_early_media=true has a better chance of success for T38 fax transmissions.
Setting this as a fax variable in default settings is enough for most cases where a successful transmission occurs on the first attempt. However if fax retries are needed this variable was ignored until now.
This change ensures that IF the user sets ignore_early_media=true as a default fax setting it will also be used for fax retry scenarios when T38 is enabled. If ignore_early_media is not set to true then the changes here are ignored thus minimizing risk.
IBM Watson supports MP3 transcription and my testing shows it is very similar to WAV in terms of overall quality.
The benefit, of course is it greatly reduces the voicemail file size.
If MP3 is not set for the system then it will use WAV.
If other users prefer having the option of MP3 for the system but WAV for Watson transcription we could add a new variable for Watson transcription and add this new variable as a qualifier.
When we have MP3 enabled we want ALL voicemails to be MP3 EXCEPT the ones that need to be transcribed, which will be WAV.
When transcribe_enabled is set to true, ALL voicemails currently become WAV even when MP3 is set.
This change ensures that ALL voicemails remain MP3 except the extensions that have voicemail_transcription_enabled set to true.
Note: The reason this was not working is because setting transcribe_enabled to true also sets voicemail_transcription_enabled to false for ALL extensions BUT it is not written into the database. Therefore a SAVE is required for ALL voicemails to ensure this field is written to the database. Changing to ~=true gets around this problem.