* config->exists returns true or false but no action taken and variable
is unused
* remove unused variable db_type
* remove unused variable db_name
* remove unused variable db_username
* remove unused variable db_password
* remove unused variable db_secure
* remove unused variable db_cert_authority
* remove unused variable db_host
* remove unused variable db_path
* remove unused variable db_port
* remove unused variable db. The upgrade method never uses the db variable
and instead uses a new database connection each time.
* remove uninitialized parameters variable
* domain_count never used
* variable context is never used in the method or any app_defaults
* variable $row is clobbered by inner foreach loop
* variable domain_name is never used in method scope
* variable domain_array seems to be uninitialized in this scope so set an
empty string value so function lower_case is not receiving null.
This commit adds support for PostgreSQL TLS communication. This requires /etc/fusionpbx/config.php to have two parameters added:
$db_secure = true;
$db_cert_authority = "/path/to/ca.crt";
if a application is installed via a symlink PHP will resolve the symlink
for __DIR__ and __FILE__ making it impossible for an application to work
out it's relative path withing the fusion system.
By providing $app_path during upgrade routines an application will
beable to provide the correct link for menu items (e.g.
/opt/languages/index.php) instead of having to hard code it where it
could change depending on how the application was installed
enable display_type on domains (and therefore app_defaults)
capture the output of app_defaults
format if statements to project preference
use more generic label display for results reducing number of translations required
change upgrade.php to use the more consistent $display_type
So, please find in this set numerous small changes which eliminate numerous php warning messages.
Also, a small bug fix in an sql statistics routine, naming a count(*) field as count, so displaying correct detail.
If any of the proposed changes are omitted, the relevant page will experience php warnings.
There are no doubt fusionpbx pages I've yet to visit that still generate warnings, this set is nearly certainly not comprehensive.
FusionPBX
fusionate
frytimo
Nate
agree
jpattWPC
Mafoo
Harry G. Coin
Matthew Vale