If the settings object is not passed in the parameters the settings object that was created did not have the current domain uuid or user uuid set. This would cause default settings that were copied to the domain to be ignored. Ensuring the domain_uuid and user_uuid are initialized before the setting object and then passing them to the settings object constructor will make sure that the values would be returned when a request to the settings object is made.
The method overwrites the object property initially set when the method is called. This causes any subsequent calls to be incorrect. Removing this keeps the initial objects property intact. The method voicemail_messages is only used internally from the messages method for getting message details in the voicemails. This has been set to a private method to reflect this type of use.
Authored-by: Tim Fry <tim@fusionpbx.com>
Update comparison checks when testing the database status and
add a unified log message with a more detailed message from the
database when there is a failure
Authored-by: Tim Fry <tim@fusionpbx.com>
- Allowing passing the database object into the constructor
- Add the database object in the constructor
- replace $_SESSION['domain_uuid'] and $_SESSION['user_uuid'] with $this->domain_uuid and $this->user_uuid
* update voicemail with the latest changes to the maintenance application
Update the public static function filesystem_maintenance in voicemail
class to use the newest changes in the maintenance class. The
maintenance class now has a constant defined for the subcategory used
within the project.
* update app_config file with necessary default setting changes
---------
Authored-by: Tim Fry <tim@fusionpbx.com>
* Add documentation to methods. Use is_resource for added type detection
* Allow connect to specify timeout in microseconds with default 30,000
* Update calling mechanism for event sockets
* Update project for new singleton event sockets
* remove unused variable
* catch errors on closing the socket
bug: voicemail_id was never set so wrong path constructed and glob finds no matching files.
test case:
delete a voicemail message from the web interface
expected result:
voicemail is deleted in the database + file system
actual results:
voicemail is still on the file system
So, please find in this set numerous small changes which eliminate numerous php warning messages.
Also, a small bug fix in an sql statistics routine, naming a count(*) field as count, so displaying correct detail.
If any of the proposed changes are omitted, the relevant page will experience php warnings.
There are no doubt fusionpbx pages I've yet to visit that still generate warnings, this set is nearly certainly not comprehensive.
frytimo
fusionate
FusionPBX
FusionPBX
Finn
Nate
Alexey Melnichuk
jebsolutions
Harry G. Coin
reliberate