dbxe/fusionpbx
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

remove instances where a pointer is used in a foreach loop for value (#7108)

Browse Source
This commit is contained in:
frytimo
2024-08-22 12:41:10 -06:00
committed by GitHub
parent 0583c5b429
commit 2cbb4dbc31
73 changed files with 170 additions and 170 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/extensions/extension_edit.php
+4 -4
View File
@@ -1474,7 +1474,7 @@
if (!empty($destinations)) {
echo " <select name='outbound_caller_id_name' id='outbound_caller_id_name' class='formfld'>\n";
echo " <option value=''></option>\n";
foreach ($destinations as &$row) {
foreach ($destinations as $row) {
if(!empty($row["destination_caller_id_name"])){
if (!empty($outbound_caller_id_name) && $row["destination_caller_id_name"] == $outbound_caller_id_name) {
echo " <option value='".escape($row["destination_caller_id_name"])."' selected='selected'>".escape($row["destination_caller_id_name"])."</option>\n";
@@ -1511,7 +1511,7 @@
if (!empty($destinations)) {
echo " <select name='outbound_caller_id_number' id='outbound_caller_id_number' class='formfld'>\n";
echo " <option value=''></option>\n";
foreach ($destinations as &$row) {
foreach ($destinations as $row) {
$tmp = $row["destination_caller_id_number"];
if(empty($tmp)){
$tmp = $row["destination_number"];
@@ -1552,7 +1552,7 @@
if (!empty($emergency_destinations)) {
echo " <select name='emergency_caller_id_name' id='emergency_caller_id_name' class='formfld'>\n";
echo " <option value=''></option>\n";
foreach ($emergency_destinations as &$row) {
foreach ($emergency_destinations as $row) {
$tmp = $row["destination_caller_id_name"];
if(empty($tmp)){
$tmp = $row["destination_description"];
@@ -1598,7 +1598,7 @@
if (permission_exists('emergency_caller_id_select_empty')) {
echo " <option value=''></option>\n";
}
foreach ($emergency_destinations as &$row) {
foreach ($emergency_destinations as $row) {
$tmp = $row["destination_caller_id_number"];
if(empty($tmp)){
$tmp = $row["destination_number"];
app/extensions/resources/classes/extension.php
+2 -2
View File
@@ -216,7 +216,7 @@ if (!class_exists('extension')) {
$call_group = $row['call_group'] ?? '';
$call_group = str_replace(";", ",", $call_group);
$tmp_array = explode(",", $call_group);
foreach ($tmp_array as &$tmp_call_group) {
foreach ($tmp_array as $tmp_call_group) {
$tmp_call_group = trim($tmp_call_group);
if (!empty($tmp_call_group)) {
if (empty($call_group_array[$tmp_call_group])) {
@@ -508,7 +508,7 @@ if (!class_exists('extension')) {
$xml .= " to keep searching for the user in the directory.\n";
$xml .= " -->\n";
$extension_array = explode(",", $extension_list);
foreach ($extension_array as &$tmp_extension) {
foreach ($extension_array as $tmp_extension) {
$xml .= " <user id=\"$tmp_extension\" type=\"pointer\"/>\n";
}
$xml .= " </users>\n";
app/extensions/resources/dashboard/caller_id.php
+1 -1
View File
@@ -278,7 +278,7 @@
if (count($destinations) > 0) {
echo "<select class='formfld' name='extensions[".$x."][outbound_caller_id]' id='outbound_caller_id_number_".$x."' style='width: 100%; min-width: 150px;'>\n";
echo " <option value=''></option>\n";
foreach ($destinations as &$field) {
foreach ($destinations as $field) {
if (!empty($field['destination_caller_id_number'])) {
echo "<option value='".escape($field['destination_caller_id_name'])."@".escape($field['destination_caller_id_number'])."' ".($row['outbound_caller_id_number'] == $field['destination_caller_id_number'] ? "selected='selected'" : null).">".escape($field['destination_caller_id_name'])." ".escape($field['destination_caller_id_number'])."</option>\n";
}