test #1:
enter an invalid command for the shell. e.g. "asdf" then click execute.
expected result:
You get some type of result about invalid command.
Actual result: nothing shows up. You have no idea if your command worked or not.
fixed result: When doing an exec include errors in the response: 2>&1
Test #2:
Enter something invalid in the switch command. e.g. "asdf". Click Execute. Change to SQL. Enter something valid e.g. "select * from v_users;" Click execute.
Expected result:
You see the SQL output right below your "select * from v_users;" input text box.
Actual result:
Because the output from the previous switch/php/shell is not hidden the SQL output is pushed down off the screen. Unless the user scrolls down they will not see the result and think their SQL command didn't actually work.
Fixed results:
When you do switch/phps/shell show the Response section.
When you do sql hide the response section.
This way only the relevant response/sql_response is shown to avoid confusion/screen clutter.
Please do further testing/review and give comments and suggest cleanup, etc.
This bug is only tripped if all of the following are true:
a) fax send fails
b) email notification of fax failure also fails
c) Other?
how to test
- have a 100% working fax to email setup.
- Change Advanced->defaults->email and set the port to be something invalid.
- e.g. smtp port 9999 is invalid
- send a test fax to something without a fax
- e.g. I just faxed my own DID which does NOT have fax answering
- each time the phone rings answer...wait 5 seconds, and then hang up
- note: it will retry sending the fax 5 times so repeat the above.
- on the last try it will give up, and try to send the failure email
- the email will fail (bad port) and then it will insert the failed email into v_emails
- the insert will fail and nothing in v_emails
Error was caused by trying to insert '' into the domain_uuid field.
'' is invalid in a uuid field, but null is okay.
The null is caused by no x-headers being passed. So these two fields end up null:
$headers["X-FusionPBX-Domain-UUID"]
$headers["X-FusionPBX-Email-Type"]
Ignoring unset/uninitialized variables hides bugs.
Fix: feed the X-Header in the calling lua code.
test:
- enable all errors
- go to log view page
expected result:
- no warnings/notify/errors
actual result:
Notice: Undefined index: ln in /var/www/fusionpbx/app/log_viewer/log_viewer.php on line 48
Notice: Undefined index: ord in /var/www/fusionpbx/app/log_viewer/log_viewer.php on line 51
Notice: Undefined index: fs in /var/www/fusionpbx/app/log_viewer/log_viewer.php on line 54
Notice: Undefined index: a in /var/www/fusionpbx/app/log_viewer/log_viewer.php on line 57
Notice: Undefined index: filter in /var/www/fusionpbx/app/log_viewer/log_viewer.php on line 81
Notice: Undefined variable: byte_count in /var/www/fusionpbx/app/log_viewer/log_viewer.php on line 221
Notice: Use of undefined constant color - assumed 'color' in /var/www/fusionpbx/app/log_viewer/log_viewer.php on line 246
Notice: Use of undefined constant font - assumed 'font' in /var/www/fusionpbx/app/log_viewer/log_viewer.php on line 246
Notice: Undefined variable: line_num in /var/www/fusionpbx/app/log_viewer/log_viewer.php on line 270
bug: voicemail_id was never set so wrong path constructed and glob finds no matching files.
test case:
delete a voicemail message from the web interface
expected result:
voicemail is deleted in the database + file system
actual results:
voicemail is still on the file system
* show git branch + commit. +link to preview git changes
new feature
- bottom of upgrade screen shows git branch + commit you are on
- provides a link to github showing changes since then on your current branch
More eyes reviewing the code is always a plus. The github link helps make it easier.
* Update index.php
Add translations and pretty it up a little.
prerequisite:
- add at least one backup path to the Advanced->defaults
- do NOT install rar archive/de-archive programs
test case #1
- go to backup screen and download backups as rar
test case #2
- go to backup screen and upload a RAR file
expected result:
- get a sign that an error occurs
actual result:
- not clear if it failed, or why
fix:
added error message. And you will get the top-bar warning in red on error instead of in green.
note: cut-pasted from google translate for "extraction failed" part of message-restore_failed_extract
test case:
Create a new ring group with one extension.
Immediately dial the ring group number.
expected result:
Phone rings. No errors in log.
actual result:
Call terminates and log has "0" as ring_group_uuid and a sql error.
Note: editing and re-saving the ring group works around the problem
The Problem:
Line 162: non-existent variable...being checked is returned as false = 0
Line 278: Xml gets generated with bogus zero...
Line 298: Generate a new uuid...but too late. We already generated the xml dial plan which will be invalid until we edit and resave this ring group.
fix:
Generate uuid before generating xml
* fix orphan v_ring_group_users after deleting ring group
steps to test:
create a ring group with one extension and one user. This will add one user to v_ring_group_users. Delete the ring group.
expected result:
ring group and all it's components are deleted
actual result
v_ring_group_user entry for this ring group is not deleted.
This fix: deletes v_ring_group_user when ring group is deleted.
* Update ring_group_delete.php
* Update ring_group_delete.php
Remove the hidden spaces
* [master] include stderr in git pull results and check for error
Old result (seems correct but actually failed):
Updating d190f6a..d958bea
Corrected result (includes failure message):
Updating d190f6a..d958bea
error: Your local changes to the following files would be overwritten by merge:
app/fax/fax_log_view.php
Please, commit your changes or stash them before you can merge.
* tab fixes
+ fix: duplicate check only within same default_setting_category. This fixes the bug where "keep_local" for fax wasn't being created because there was a "keep_local" for voicemail. Without this fix you will get a lua error due to the field not being set and nothing shows up in the sent faxes log.
fax/fax_log_view.php:
+ fix: back button text is missing. Copied correct localized text code from another fax page that worked.
app/fax/app_config.php
+ fix: date field is now timestamp for postgres+mysql. This fixes the listing only showing the date, not the time as well.
Note: app->defaults doesn't change field types. Existing installs will have to manually update the field type e.g. for postgres:
sudo -sHu postgres
\d fusionpbx
alter table v_fax_logs alter column fax_date type timestamp without time zone;
\q
Expected result: The person at extension XXX is unavailable ...
Actual result: The person at is unavailable...
i.e. it doesn't say the extension number.
bug: trying to access local variable voicemail_greet_id outside it's scope...so it doesn't exist and you get this in the logs:
2016-09-18 12:32:54.615249 [ERR] switch_cpp.cpp:977 Error! invalid args.
Fix moves local variable creation outside the inner "if" so it's available for the later table.insert
jebsolutions