test case:
Create a new ring group with one extension.
Immediately dial the ring group number.
expected result:
Phone rings. No errors in log.
actual result:
Call terminates and log has "0" as ring_group_uuid and a sql error.
Note: editing and re-saving the ring group works around the problem
The Problem:
Line 162: non-existent variable...being checked is returned as false = 0
Line 278: Xml gets generated with bogus zero...
Line 298: Generate a new uuid...but too late. We already generated the xml dial plan which will be invalid until we edit and resave this ring group.
fix:
Generate uuid before generating xml
* fix orphan v_ring_group_users after deleting ring group
steps to test:
create a ring group with one extension and one user. This will add one user to v_ring_group_users. Delete the ring group.
expected result:
ring group and all it's components are deleted
actual result
v_ring_group_user entry for this ring group is not deleted.
This fix: deletes v_ring_group_user when ring group is deleted.
* Update ring_group_delete.php
* Update ring_group_delete.php
Remove the hidden spaces
* [master] include stderr in git pull results and check for error
Old result (seems correct but actually failed):
Updating d190f6a..d958bea
Corrected result (includes failure message):
Updating d190f6a..d958bea
error: Your local changes to the following files would be overwritten by merge:
app/fax/fax_log_view.php
Please, commit your changes or stash them before you can merge.
* tab fixes
+ fix: duplicate check only within same default_setting_category. This fixes the bug where "keep_local" for fax wasn't being created because there was a "keep_local" for voicemail. Without this fix you will get a lua error due to the field not being set and nothing shows up in the sent faxes log.
fax/fax_log_view.php:
+ fix: back button text is missing. Copied correct localized text code from another fax page that worked.
app/fax/app_config.php
+ fix: date field is now timestamp for postgres+mysql. This fixes the listing only showing the date, not the time as well.
Note: app->defaults doesn't change field types. Existing installs will have to manually update the field type e.g. for postgres:
sudo -sHu postgres
\d fusionpbx
alter table v_fax_logs alter column fax_date type timestamp without time zone;
\q
Expected result: The person at extension XXX is unavailable ...
Actual result: The person at is unavailable...
i.e. it doesn't say the extension number.
bug: trying to access local variable voicemail_greet_id outside it's scope...so it doesn't exist and you get this in the logs:
2016-09-18 12:32:54.615249 [ERR] switch_cpp.cpp:977 Error! invalid args.
Fix moves local variable creation outside the inner "if" so it's available for the later table.insert
jebsolutions